Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Autentication should implement new API gapi.auth2 #40

Open
fernando-lopez opened this issue Sep 4, 2015 · 6 comments
Open

Autentication should implement new API gapi.auth2 #40

fernando-lopez opened this issue Sep 4, 2015 · 6 comments

Comments

@fernando-lopez
Copy link

Google has recently updated the API Sign-in Libraries. It should be replaced by the currently used in the project

More details here https://developers.google.com/identity/sign-in/web/reference

@maximepvrt
Copy link
Owner

I look that soon.
If you you want, you can add this with a pull request

@fernando-lopez
Copy link
Author

@maximepvrt do you have in mind update the library to oauth 2.0?

The library auth is already deprecated https://developers.google.com/api-client-library/javascript/reference/referencedocs#gapiauthauthorizeparams--------callback

There is a risk to impact the apps using this project in case Google disable the library.

@EugeneZ
Copy link

EugeneZ commented Nov 28, 2016

Something to be aware of: The new gapi.auth2 API does not work when the "third party cookies" checkbox in Chrome is ticked, nor in Safari or Chrome's Private Browsing mode, or any other system where third party use of sessionStorage is limited. They have no plans to fix this. So if you upgrade it could actually cause more problems.

google/google-api-javascript-client#246

@lukewlms
Copy link

lukewlms commented Nov 1, 2017

@EugeneZ Thanks for the info. This seems crazy. Disabling third party cookies is a recommended privacy practice.

@EugeneZ
Copy link

EugeneZ commented Nov 1, 2017

@lukecwilliams It looks like they might be fixing it, maybe. In the meantime, I have replaced all use of GAPI's javascript client with regular OAuth and REST libraries.

@lukewlms
Copy link

lukewlms commented Nov 2, 2017

@EugeneZ Thanks for the response. We are rolling back the effort to use pop-up authentication, and implementing only the Authentication URL version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants