Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section in the README about withCustomDio #270

Closed
brunoocasali opened this issue Mar 15, 2023 · 2 comments · Fixed by #380
Closed

Add a section in the README about withCustomDio #270

brunoocasali opened this issue Mar 15, 2023 · 2 comments · Fixed by #380
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

After the #266 implementation, it is now possible to use a custom implementation of the HTTP library in this package.

This issue aims to create a small section in the README explaining how to use this feature. Check the test file test/custom_dio_test.dart for more information.

@brunoocasali brunoocasali added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 15, 2023
@ahmednfwela
Copy link
Collaborator

do we need to update the code samples as well ?

@brunoocasali
Copy link
Member Author

Not for this case, this is only a dart thing, the code-samples is only for features shared between all the integrations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants