-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute to node-sass #13
Comments
This is a marvelous idea. I noticed the issue with chokidar had been open for some time on node-sass and wasn't sure if it was a planned move, hence, node-sass-chokidar. |
Awesome. That old PR has been problematic for a couple reasons
We didn't believe the risk of potentially destabilizing the watcher for millions of users was worth the potential benefits. Now that we have confidence in our testing around the watcher the risk of destabilisation is much lower and we're very much open to making the switch if it benefits the wider community. |
Since node-sass compiles If not then this project should probably continue independently to provide a clean and reliable workaround, especially since it is recommended by Facebook for create-react-app as well. |
@xzyfer, @Livven is right. node-sass-chokidar is a great workaround for some currently unsolved problems in node-sass. @michaelwayman please consider keeping node-sass-chokidar active at least until the following node-sass bug is resolved: sass/node-sass#1758 |
We're working on node-sass@5 which brings in many of the benefits of node-sass-chokidar. |
Definitely agree with @RoyTinker in keeping this project running separately. The smallest of changes within this wrapper really lends itself to usability on a day-to-day basis, and is in part due to being decoupled from the sass/node-sass project. For example, something as simple and standard as compiling before watching has long been a part of node-sass-chokidar, despite being rejected several times on the main project. While this is on the radar for its next release, it's almost been exactly a year since @xzyfer's mention of node-sass@5: which is still yet to be released. It's understandable that a vastly popular project like sass/node-sass needs time to ensure comprehensive checks are carried out before making any "drastic" changes. I think that's the exact reason why projects such as node-sass-chokidar should continue alongside to continue pushing forward. Thanks for your time and effort, @michaelwayman, really appreciate it! 👍 |
Hello 👋
I'm the maintainer of node-sass. I'd love for us to work together to move some of these changes upstream.
Forking node-sass in this way is going to quickly result in divergence, and may negatively impact the community. For instance we're actively working to overhaul the CLI. Notable we've recently made changes to the watcher integration to allow use to move away from Gaze. Previously this simple wasn't possible to due issue with testing the watcher functionality reliably.
We'd welcome an up-to-date PR for chokidar integration :)
The text was updated successfully, but these errors were encountered: