Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dynatrace-metric-utils 1.7.1 #3825

Closed
jonatan-ivanov opened this issue May 8, 2023 · 3 comments
Closed

Upgrade to dynatrace-metric-utils 1.7.1 #3825

jonatan-ivanov opened this issue May 8, 2023 · 3 comments
Assignees
Labels
dependency-upgrade A dependency upgrade registry: dynatrace A Dynatrace Registry related issue
Milestone

Comments

@jonatan-ivanov
Copy link
Member

No description provided.

@jonatan-ivanov jonatan-ivanov added registry: dynatrace A Dynatrace Registry related issue dependency-upgrade A dependency upgrade labels May 8, 2023
@jonatan-ivanov jonatan-ivanov added this to the 1.11.0 milestone May 8, 2023
@jonatan-ivanov jonatan-ivanov self-assigned this May 8, 2023
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.11.0, 1.next May 8, 2023
@jonatan-ivanov
Copy link
Member Author

jonatan-ivanov commented May 8, 2023

It seems the behavior changed, the build is failing if we upgrade (jonatan-ivanov@0626db3). This is probably because of a new behavior introduced in dynatrace-oss/dynatrace-metric-utils-java#29, see isDimensionValid

See the failure on the build scan: https://ge.micrometer.io/s/acijagpuypmjg/tests/overview?outcome=failed

org.opentest4j.AssertionFailedError:
    expected: "my.gauge,tag1=value1,dt.metrics.source=micrometer,tag2= gauge,1.23 1683566417583"
    but was: "my.gauge,tag1=value1,dt.metrics.source=micrometer gauge,1.23 1683566417583"
org.opentest4j.AssertionFailedError:
    expected: "my.counter,tag1=value1,dt.metrics.source=micrometer,tag2= count,delta=0.0 1683566417993"
    but was: "my.counter,tag1=value1,dt.metrics.source=micrometer count,delta=0.0 1683566417993"

@jonatan-ivanov jonatan-ivanov added waiting for feedback We need additional information before we can continue blocked An issue that's blocked on an external project change labels May 8, 2023
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.next, 1.12 backlog May 8, 2023
@jonatan-ivanov
Copy link
Member Author

According to @pirgeo, the Dynatrace V2 API behavior was changed to match this behavior so the users will see the same thing, we can fix our broken tests to match this behavior.

@jonatan-ivanov jonatan-ivanov removed waiting for feedback We need additional information before we can continue blocked An issue that's blocked on an external project change labels May 9, 2023
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.12 backlog, 1.12.0-M1 May 9, 2023
@pirgeo
Copy link
Contributor

pirgeo commented May 10, 2023

Thanks for taking care of this. The Dynatrace API behavior has not changed. The only difference is that empty dimension values are now dropped on the client side instead of being dropped on the server side. In theory, this would save a bit of network bandwidth if someone sent a lot of dimensions with empty values, but in practice, I think this is negligible.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade A dependency upgrade registry: dynatrace A Dynatrace Registry related issue
Projects
None yet
Development

No branches or pull requests

2 participants