Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ExponentialHistogram in OTLP #3861

Closed
lenin-jaganathan opened this issue May 27, 2023 · 4 comments · Fixed by #3959
Closed

Support ExponentialHistogram in OTLP #3861

lenin-jaganathan opened this issue May 27, 2023 · 4 comments · Fixed by #3959
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone

Comments

@lenin-jaganathan
Copy link
Contributor

Please describe the feature request.
ExponentialHistogram was proposed in this OTEP (OpenTelemetry Enhancement Proposal) and was made stable by open-telemetry/opentelemetry-specification#3041. Exponential Histograms advantages are documented in the OpenTelemetry documents to list a few - configuration free, can record highly dynamic values, fully mergeable (the merging is lossy but errorless).
Micrometer should support exporting ExponentialHistogram when the export happens through OTLPMeterRegistry. The expectation is that for the use-case where service level objectives are defined, we will continue to use ExplicitBucketHistograms (It completely makes sense for a use-case where the objective is to track/observe the signals based on a set of pre-defined SLAs rather than the auto-generated one and also very cheaper when there are less SLO's involved), but when percentilesHistogram() is enabled the flavor of the histogram can either be ExplicitBucketHistogram or ExponentialHistogram based on the config supplied during Registry creation time (there is also an environmental variable available for this).

Rationale
This allows the export of ExponentialHistogram for which some of the benefits are mentioned above.

References:

@shakuzen shakuzen added enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related and removed waiting-for-triage labels Jun 9, 2023
@shakuzen shakuzen added this to the 1.x milestone Jun 9, 2023
@shakuzen shakuzen modified the milestones: 1.x, 1.14.x Jul 18, 2024
@shakuzen shakuzen changed the title Add support to export ExponentialHistogram in OTLP Support ExponentialHistogram in OTLP Aug 9, 2024
@shakuzen shakuzen modified the milestones: 1.14.x, 1.14.0-M2 Aug 13, 2024
@lenin-jaganathan
Copy link
Contributor Author

This might need a spring-boot actuator change as well.

@shakuzen
Copy link
Member

Do you mean for the new OtlpConfig methods to be supported as Spring Boot configuration properties? We'll make sure the Boot team is aware. We can hopefully get that added in time for the upcoming Spring Boot milestone.

@snicoll
Copy link
Contributor

snicoll commented Aug 13, 2024

See spring-projects/spring-boot#41837

@shakuzen
Copy link
Member

shakuzen commented Sep 6, 2024

We would love to hear any feedback from users that have tried this new feature out in milestones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants