Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JettyConnectionMetrics#addToAllConnectors does not configure bytes in/out metrics #5092

Closed
shakuzen opened this issue May 13, 2024 · 0 comments
Closed

JettyConnectionMetrics#addToAllConnectors does not configure bytes in/out metrics #5092

shakuzen opened this issue May 13, 2024 · 0 comments
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Milestone
1.13.0

Comments

@shakuzen
Copy link
Member

Mentioned during review in #4514 (comment). Doing this is a little tricky as we need to use reflection due to the change in method from Jetty 9 to 12 used to set the NetworkTrafficListener.
@shakuzen shakuzen added bug A general bug module: micrometer-core An issue that is related to our core module instrumentation An issue that is related to instrumenting a component labels May 13, 2024
@shakuzen shakuzen added this to the 1.13.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
1 participant
@shakuzen