Disable kotlinSourcesJar since it conflicts with sourcesJar

[refeccd]

This is the archive of the source jar in the central repository

https://repo1.maven.org/maven2/io/micrometer/micrometer-core/1.13.0/micrometer-core-1.13.0-sources.jar

It looks like it adds an extra layer of main directory?

[jonatan-ivanov]

Thank you for the issue!
I'm not sure what is causing this yet, it seems:

• The latest 1.12.x does not have this issue: micrometer-core-1.12.7-sources.jar
• Neither other 1.13.x jars like micrometer-commons-1.13.1-sources.jar (I spot-checked a few more)
• The first milestone release have it: micrometer-core-1.13.0-M1-sources.jar
• I can repro this locally:

git checkout v1.13.0
./gradlew -Prelease.disableGitChecks=true -Prelease.useLastTag=true -Prelease.stage=milestone final pTML -x test

• But if I just run pTML, I can't:

./gradlew pTML

Diffing 1.12.x with 1.13.x does not help much, I can't see any suspicious changes.

I'm continuing the investigations tomorrow but is this causing any issues to you right now? Can the IDE automatically attach source for 1.13.0?

[jonatan-ivanov]

I investigated this a bit further, I found a simpler way of reproducing it (than the above) with micrometer-core (1.13.x) if I run sourcesJar and pTML (publishToMavenLocal) together:

./gradlew :micrometer-core:sourcesJar :micrometer-core:pTML -x check --console=plain --no-build-cache

If I run just one of these tasks or run them after each other in separate gradle commands, I cannot repro it so these are ok:

./gradlew :micrometer-core:sourcesJar -x check --console=plain --no-build-cache
./gradlew :micrometer-core:pTML -x check --console=plain --no-build-cache

It seems I can "fix" this by downgrading the Kotlin plugin(!), i.e. changing this line:

micrometer/micrometer-core/build.gradle

Line 2 in 1061499

alias(libs.plugins.kotlin19)

to

alias(libs.plugins.kotlin17)

Here are the steps you should be able to repro this too (first checkout 1.13.x):

./gradlew clean
rm -rf ~/.gradle/caches/build-cache-1/
./gradlew :micrometer-core:sourcesJar :micrometer-core:pTML -x check --console=plain --no-build-cache
unzip -l micrometer-core/build/libs/micrometer-core-*-sources.jar | head -n20

Then downgrade the Kotlin plugin: alias(libs.plugins.kotlin17) instead of alias(libs.plugins.kotlin19) in micrometer-core/build.gradle and the main folder should be gone.

I tried to upgrade the Kotlin plugin from 1.9.23 to 1.9.24, it did not help.

There is another interesting thing I found, the META-INF folder contains only the MANIFEST.MF file when main is the root folder (I don't think this is a problem, the "norlam jar contains the necessary files").
When main folder is not present (Kotlin 1.7 plugin):

Archive:  micrometer-core/build/libs/micrometer-core-1.13.3-SNAPSHOT-sources.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  07-09-2024 13:24   META-INF/
      817  07-09-2024 13:24   META-INF/MANIFEST.MF
      762  07-09-2024 13:24   META-INF/micrometer-core.properties
        0  07-09-2024 11:50   META-INF/native-image/
        0  07-09-2024 11:50   META-INF/native-image/io.micrometer/
        0  07-09-2024 11:50   META-INF/native-image/io.micrometer/micrometer-core/
      871  07-09-2024 11:50   META-INF/native-image/io.micrometer/micrometer-core/reflect-config.json
      541  07-09-2024 11:50   META-INF/native-image/io.micrometer/micrometer-core/proxy-config.json
        0  11-17-2023 16:20   io/
        0  11-17-2023 16:20   io/micrometer/
        0  03-15-2024 14:07   io/micrometer/core/

When main folder is present (Kotlin 1.9 plugin):

Archive:  micrometer-core/build/libs/micrometer-core-1.13.3-SNAPSHOT-sources.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  02-01-1980 00:00   META-INF/
       25  02-01-1980 00:00   META-INF/MANIFEST.MF
        0  02-01-1980 00:00   main/
        0  02-01-1980 00:00   main/io/
        0  02-01-1980 00:00   main/io/micrometer/
        0  02-01-1980 00:00   main/io/micrometer/core/

[jonatan-ivanov]

It seems the kotlinSourcesJar task does this (it overwrites the jar generated by sourcesJar).
If kotlinSourcesJar runs first, there is no main folder:

./gradlew :micrometer-core:kotlinSourcesJar :micrometer-core:sourcesJar --no-build-cache

If sourcesJar runs first, the main folder is present:

./gradlew :micrometer-core:sourcesJar :micrometer-core:kotlinSourcesJar --no-build-cache

or just:

./gradlew :micrometer-core:sourcesJar --no-build-cache

and

./gradlew :micrometer-core:kotlinSourcesJar --no-build-cache

This seems to be the same issue: https://youtrack.jetbrains.com/issue/KT-54207/Kotlin-has-two-sources-tasks-kotlinSourcesJar-and-sourcesJar-that-archives-sources-to-the-same-artifact

Disabling kotlinSourcesJar resolves the issue.

[jonatan-ivanov]

I think this should be fixed in earlier versions too (whenever we use the Kotlin plugin): 1.12.x since that's the oldest OSS supported branch.

[jonatan-ivanov]

The new snapshot is published, you can see the diff between the old sources jar and the new one:

• old, not fixed: https://repo.spring.io/artifactory/snapshot/io/micrometer/micrometer-core/1.13.3-SNAPSHOT/micrometer-core-1.13.3-20240709.034046-1-sources.jar
• new, fixed: https://repo.spring.io/artifactory/snapshot/io/micrometer/micrometer-core/1.13.3-SNAPSHOT/micrometer-core-1.13.3-20240709.230322-2-sources.jar