Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uuid package introduced from Speech SDK broke IE11 #3718

Closed
compulim opened this issue Feb 12, 2021 · 0 comments · Fixed by #3726
Closed

uuid package introduced from Speech SDK broke IE11 #3718

compulim opened this issue Feb 12, 2021 · 0 comments · Fixed by #3726
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.
Milestone
R12

Comments

@compulim
Copy link
Contributor

Screenshots

In node_modules/uuid/dist/stringify.js:

image

Version

master after bumping Speech SDK.

Describe the bug

uuid accidentally introduced a bug that broke IE11 because of using default parameters.

Steps to reproduce

  1. Open 01.c.es5 sample in IE11
  2. Type markdown

Expected behavior

It should render Markdown correctly.

There should be no errors in the log.

Additional context

uuidjs/uuid#551

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Feb 12, 2021
@compulim compulim mentioned this issue Feb 12, 2021
Closed
@compulim compulim added R12 and removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 12, 2021
@compulim compulim added this to the R12 milestone Feb 12, 2021
@compulim compulim self-assigned this Feb 12, 2021
@compulim compulim mentioned this issue Feb 16, 2021
Merged
11 tasks
@compulim compulim mentioned this issue Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
R12
Development

Successfully merging a pull request may close this issue.

Remove mainFields in webpack.config.js compulim/BotFramework-WebChat
1 participant
@compulim