From 9d41d0efaf90ef8051f72d71bfdba9a3908a943b Mon Sep 17 00:00:00 2001 From: alex-peck <53013351+alex-peck@users.noreply.github.com> Date: Tue, 11 May 2021 12:09:52 -0400 Subject: [PATCH] Make artifact type check case-insensitive (#3396) --- .../Artifact/ArtifactProviderFactory.cs | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Agent.Plugins/Artifact/ArtifactProviderFactory.cs b/src/Agent.Plugins/Artifact/ArtifactProviderFactory.cs index 9d18abbe58..b642c48633 100644 --- a/src/Agent.Plugins/Artifact/ArtifactProviderFactory.cs +++ b/src/Agent.Plugins/Artifact/ArtifactProviderFactory.cs @@ -25,23 +25,23 @@ public ArtifactProviderFactory(AgentTaskPluginExecutionContext context, VssConne public IArtifactProvider GetProvider(BuildArtifact buildArtifact) { - IArtifactProvider provider; string artifactType = buildArtifact.Resource.Type; - switch (artifactType) + if (PipelineArtifactConstants.PipelineArtifact.Equals(artifactType, StringComparison.CurrentCultureIgnoreCase)) { - case PipelineArtifactConstants.PipelineArtifact: - provider = pipelineArtifactProvider; - break; - case PipelineArtifactConstants.Container: - provider = fileContainerProvider; - break; - case PipelineArtifactConstants.FileShareArtifact: - provider = fileShareProvider; - break; - default: - throw new InvalidOperationException($"{buildArtifact} is not of type PipelineArtifact, FileShare or BuildArtifact"); + return pipelineArtifactProvider; + } + else if (PipelineArtifactConstants.Container.Equals(artifactType, StringComparison.CurrentCultureIgnoreCase)) + { + return fileContainerProvider; + } + else if (PipelineArtifactConstants.FileShareArtifact.Equals(artifactType, StringComparison.CurrentCultureIgnoreCase)) + { + return fileShareProvider; + } + else + { + throw new InvalidOperationException($"{buildArtifact} is not of type PipelineArtifact, FileShare or BuildArtifact"); } - return provider; } } }