Local O365: Groups and Teams endpoints needs pagination

[joaop221]

Some Azure user's fields (e.g.: Groups and Teams) has an one to N relationship, so them need to be called with pagination.

Graph Docs:

• List joinedTeams - Graph;
• List member of - Graph;
• List transitive member of - Graph.

Non paginated API calls:

• o365-moodle/local/o365/classes/rest/unified.php

  Line 959 in f796d9d

  public function get_user_groups(string $userobjectid) : ?array {

• o365-moodle/local/o365/classes/rest/unified.php

  Line 976 in f796d9d

  public function get_user_transitive_groups(string $userobjectid) : ?array {

• o365-moodle/local/o365/classes/rest/unified.php

  Line 988 in f796d9d

  public function get_user_teams(string $userobjectid) : ?array {

Implemented API calls with pagination:

• o365-moodle/local/o365/classes/feature/usersync/main.php

  Line 332 in f796d9d

  public function get_users($params = 'default', $skiptoken = '') {

The proposal is add support to query user info with there pagination.

[douglasfernandesjr]

Great fix! In real world organizations user have a lot of groups. This gonna help me a lot

[weilai-irl]

Hi @joaop221

Thank you so much for making the PR. I have been planning to move all Graph API calls with pagination to a unified function that handles the skip tokens for very long time, but didn't find a good chance, until I see your PRs. I made a few more changes on top of your PR and moved all calls that have pagination that I know of to use the paginatedapicall() function that you created. There has been some changes to the function itself too to allow it to support a few more different use cases. I have tested all affected function briefly and they all work fine. I'll request a formal system test in this change before it's included in the next release.

Thank you again for your valuable contribution.

Regards,
Lai

[joaop221]

Hi @weilai-irl.

Is there a new due date for 2024-01 milestone's features?

[weilai-irl]

Hi @joaop221

We are aiming for the week of 11th of March if testing goes smoothly; otherwise it will be the week of 8th of April. I'm away for the three weeks in between.

Sorry for the delay.

Regards,
Lai

[weilai-irl]

Hi @joaop221

Changes in this issue are included in the releases from today.

• Release 4.1.4 for Moodle 4.1.
• Release 4.2.3 for Moodle 4.2.
• Release 4.3.1 for Moodle 4.3.

Thank you very much for reporting the issue and providing the solution.

Regards,
Lai