-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync users from Microsoft Entra ID skiptoken and deltatoken API call error #2535
Comments
I removed all the duplicate users and the issue is still in place. Is one of the App Registration API's required to call Azure in this part as we built this site from scratch, not using the powershell script only allowing the API calls for SSO not all of them for OneDrive & Teams etc. Debug mode on did not show me anymore information... |
I can confirm this same issue persists in moodle version 4.1.9 and local_o365 4.1.6 The error just started to occur after our upgrade from moodle version 4.1.7 to 4.1.9. |
Any news or idea on what this might be @weilai-irl .. upgrading to local_o365 4.1.6 & auth_oidc 4.1.6 is still showing the same issues. |
Morning @weilai-irl sorry to be a pain, looking for a solution for this. I've had some success on some sites by using Cleanup User Sync Delta Tokens in Maintenance Tools section. But this does not fix it for all sites. I've now seen this on a Moodle 4.4 site using plugins local_o365 / auth_oidc version 4.3.3 Many thanks for any help or pointers to solve the issue. Regards, |
We're having this problem too, this is what our Moodle Partner has found when investigating our issues:
For now we are limping along, with user update happening slowly, and we're often relying on users to log in to get their accounts to update. We are running:
|
Hi all, Please find the fix to the issue in the linked PR. Please test the solution and provide feedback, as there are not enough users in our test tenant to perform the test. If passed, the solution will be included in the next release. Regards, |
Thanks @weilai-irl — I've put in the request to have the PR for the 4_0_1 branch applied to our test Moodle instance. I'll report back when I have news. |
Morning @weilai-irl I can confirm that adding the changes mentioned here to local/o365/classes/rest/unified.php fixes the issue. Each Entra sync run now correctly returns a Delta sync as expected
Many thanks, |
Hi @RayCoSector Thank you for your confirmation. This will certainly be included in the next release then. Regards, |
Hi all, The fix to this issue has been included in release 4.1.7, 4.2.6 and 4.3.4 on 2nd of July 2024. I'm going to mark this issue as closed. Regards, |
Hi all,
Has anyone come across this before (see below), I'm thinking that it might be caused due to multiple accounts using the same email address in the Active Directory.
What happens is that the next sync then is a forced to do a full sync, after the full sync completes in 5 or so hours the next sync is then like the below, completing in around 1 second and the next sync is a full sync and around it goes. All seems to work okay.. it is just a little unnerving as to why it is happening ??
Moodle 4.1.9
O365 plugins 4.1.5
Regards,
Ray.
The text was updated successfully, but these errors were encountered: