Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship with embedded symbols so we get line numbers #2050

Closed
SimonCropp opened this issue Mar 7, 2022 · 4 comments · Fixed by #2051
Closed

Ship with embedded symbols so we get line numbers #2050

SimonCropp opened this issue Mar 7, 2022 · 4 comments · Fixed by #2051

Comments

@SimonCropp
Copy link
Contributor

so stuff like this is easier to debug

System.NullReferenceException: Object reference not set to an instance of an object.

System.NullReferenceException
Object reference not set to an instance of an object.
   at Microsoft.Playwright.Core.Browser.NewContextAsync(BrowserNewContextOptions options)
   at Microsoft.Playwright.Core.Browser.NewPageAsync(BrowserNewPageOptions options)
@mxschmitt
Copy link
Member

Are you interested in contributing this to the project?

@SimonCropp
Copy link
Contributor Author

absolutely. want a PR for this?

@SimonCropp
Copy link
Contributor Author

side note. what branch should PRs target. main seems to target only netstandard https://github.com/microsoft/playwright-dotnet/blob/main/src/Playwright/Playwright.csproj#L10 but the current release also targets net5 https://github.com/microsoft/playwright-dotnet/blob/release-1.19/src/Playwright/Playwright.csproj#L10

@mxschmitt
Copy link
Member

main is up2date, we recently changed the TFM to netstandard. It gets released released as stable in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants