Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph lines in tig don't render at all font sizes #10038

Closed
JelteF opened this issue May 5, 2021 · 2 comments
Closed

Graph lines in tig don't render at all font sizes #10038

JelteF opened this issue May 5, 2021 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@JelteF
Copy link

JelteF commented May 5, 2021

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

tig version 2.3.0 (inside WSL2, Ubuntu 18.04)

Steps to reproduce

  1. Set the following as font settings:
            "fontFace": "Consolas",
            "fontSize": 8
  1. open tig in a git repo on your WSL

Expected Behavior

What you see at fontsize 9:
afbeelding

Actual Behavior

At fontsize 8:
afbeelding

at fontsize 7:
afbeelding

at fontsize 6:
afbeelding

As you can see the exact lines that are missing differ based on the fontsize. I ran into this issue with fontsize 10 using this Ubuntu Mono Nerd Font, but as shown here it also reproduces with Consolas. One interesting thing is that all lines are visible with the Ubunutu font is that, on fontsize 8 and 10 all lines are visible, but on fontsize 9 not all are visible. So it's not just that the font is "too small" to display the lines.

I thought of commenting on this issue: #909, but it seems unrelated after going through the comments there.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 5, 2021
@DHowett
Copy link
Member

DHowett commented May 5, 2021

Thanks!

This looks like either /dup #7927 (if the font has bitmap strikes) or /dup #6161 (if we try to draw them too small, they will be destroyed because they went below one pixel in size)

@ghost
Copy link

ghost commented May 5, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 5, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants