Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special glyphs slightly malformed / text slightly blurry with Atlas Engine and Meslo Nerd font #14057

Closed
itsTyrion opened this issue Sep 22, 2022 · 3 comments · Fixed by #14959
Closed

Special glyphs slightly malformed / text slightly blurry with Atlas Engine and Meslo Nerd font #14057

itsTyrion opened this issue Sep 22, 2022 · 3 comments · Fixed by #14959
Assignees
@lhecker
Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@itsTyrion
Copy link

itsTyrion commented Sep 22, 2022 •
edited
Loading

Windows Terminal version

1.16.2523.0

Windows build number

10.0.19044.0

Other Software

PARTIALLY affects MacType (better font AA) but I'm mainly reporting the malformed glyphs

Steps to reproduce

Use WT preview with Atlas Engine and Meslo Nerd Font
Just to make sure, the exact font files MesloLGS-NF.zip

Expected Behavior

No response

Actual Behavior

This is without Atlas Engine (MacType enabled)
2022-09-22_02-14
This is with Atlas Engine (MacType enabled). Less clear, shapes malformed.
image
With Atlas (MacType disabled, so only clarity/sharpness is slightly affected)
image

Without Atlas (MacType disabled, very visible in the Windows glyph. Just for reference)
image
@itsTyrion itsTyrion added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 22, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 22, 2022
@itsTyrion itsTyrion changed the title some text shapes are off + less readability with atlas engine some text shapes are off + less readability with atlas engine and Meslo Nerd font Sep 22, 2022
@itsTyrion itsTyrion changed the title some text shapes are off + less readability with atlas engine and Meslo Nerd font Special glyphs slightly malformed / text slightly blurry with Atlas Engine and Meslo Nerd font Sep 22, 2022
@lhecker lhecker self-assigned this Sep 22, 2022
@lhecker
Copy link
Member

lhecker commented Sep 22, 2022 •
edited
Loading

FYI If you're curious about some of these changes, there's a lengthy discussion over here with the latest update being: #13936 (comment) In short, the blurriness appears to be correct actually/unfortunately.

In the soon to be released next 1.16 update you'll be able to specify precise fractional font sizes which will allow you to restore the previous look of glyphs. Text clarity can be improved if you enable ClearType in your settings. Finally, the reason those rounded corners look worse is because I'm incorrectly handling glyph sizes in AtlasEngine and assume that they're 1 cell wide, even though they're actually 2 cells wide. This is an issue that's specific to Nerd Fonts and is something I'm currently working on as fast as I can.

@itsTyrion
Copy link
Author

itsTyrion commented Sep 22, 2022 •
edited
Loading

Good to know, thanks for the fast reply. I'll keep it disabled for the time being and use MacType. Especially the NF symbols (OS logo, folder, git..) look a lot better for the time being.
What I don't understand is why exactly some text gets blurry with Atlas AND MacType

@zadjii-msft zadjii-msft added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Sep 23, 2022
@lhecker
Copy link
Member

lhecker commented Sep 25, 2022 •
edited
Loading

FYI I'm going to continue tracking the issue with nerd font glyphs in #14022, which was the first issue to report it.

@lhecker lhecker added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 12, 2022
@lhecker lhecker added Priority-2 A description (P2) and removed Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 12, 2022
@lhecker lhecker mentioned this issue Mar 6, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite AtlasEngine to allow arbitrary overhangs microsoft/terminal
3 participants
@lhecker @itsTyrion @zadjii-msft