Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc is slower and shows artifacts #1665

Closed
ghost opened this issue Jun 27, 2019 · 2 comments
Closed

mc is slower and shows artifacts #1665

ghost opened this issue Jun 27, 2019 · 2 comments
Labels
Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Milestone

Comments

@ghost
Copy link

ghost commented Jun 27, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]   
Windows Terminal version (if applicable): 0.2.1715.0

Screen 1920x1200
default settings for windows terminal

Steps to reproduce

  1. open Windows Terminal

  2. ssh in any shell session (tested pwsh, cmd, bash) to linux server

  3. start mc (midnight commander)

  4. scroll through folder list with arrow down/up

  5. do the same as above in pwsh or bash or cmd but started directly (without Windows Terminal)

  6. Compare performance and screen quality

Expected behavior

Performance and stability should be at least the same in both cases

Actual behavior

Windows Terminal scenario is noticeably slower.
Windows terminal blinks with artifacts (mostly |) on each scroll step when you press and hold up/down key.

Tested the same with mc in local bash session. Less artifacts and a bit improved speed but still noticable slowdown.

Seems related but not duplicate of #117

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 27, 2019
@miniksa miniksa added Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Cmd.exe The issue is related to the legacy command interpreter, CMD.exe. Product-Terminal The new Windows Terminal. labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
@miniksa miniksa added Product-Conhost For issues in the Console codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Cmd.exe The issue is related to the legacy command interpreter, CMD.exe. labels Jun 27, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 2, 2019
@zadjii-msft zadjii-msft modified the milestone: Terminal v1.0 Apr 16, 2020
@zadjii-msft
Copy link
Member

For whatever reason, this issue is weirdly bugged and not showing up in the query I've been using to triage 1.0 issues.

Thant being said, I'm thinking that this is something that's going to hopefully just magically get fixed with #778/#5185/#5345 getting merged, whenever that does.

@DHowett-MSFT
Copy link
Contributor

This was reported in 0.2, actually, before we ironed out some pty issues and some UTF-8 parsing issues that may have resulted in us corrupting things coming out of the client application. I'm going to close this one out, since it doesn't seem to repro any more (at least for me :P) and the speed seems entirely acceptable.

Thanks!

@DHowett-MSFT DHowett-MSFT added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Apr 21, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

3 participants