Bright foreground color hard-coded to be brightWhite, bold text invisible for light color schemes

[roblillack]

Environment

Windows build number: Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3291.0

Steps to reproduce

1. Select light color scheme (dark foreground color on very light background color)
2. Try to display bright text (ANSI escape code [1m) without specifying a non-default color, for example by running this in a WSL shell:

echo "this is $(tput bold)normal bright text$(tput sgr0) and this is $(tput setaf 1)$(tput bold)red bright text$(tput sgr0)."

Expected behavior

The words "normal bright text" should be visible (and, preferably, highlighted in some way or bold).

Actual behavior

Windows Terminal selects "bright white" as the default "bright foreground" color which in this case is the same as the background color. Also, compare it to the behavior of ConEmu below, that works:

Suggestion

There are multiple ways to solve this problem (which are separate from implementing bold support as discussed in #109):

1. Add an option brightForeground to the color schemes so light schemes can set it to a dark color, or
2. Add an option to ignore the [1m escape sequences altogether, or
3. Implement a better algorithm that does not hardcode using "bright white" but chooses a fitting color from the palette based on the perceived "darkness" of the background color (say, go with "bright black" for light backgrounds, "bright white" for dark backgrounds)

I strongly suggest to go with option no. 1.

[j4james]

This sounds the same as #3022, which was resolved as a duplicate of #2661 and #293.

[DHowett-MSFT]

Yep, this is a /dupe of #2661 and #293. Thanks!

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!