Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UTF-8 characters take two placeholders in render buffer #666

Closed
5HT opened this issue May 10, 2019 · 5 comments
Closed

Some UTF-8 characters take two placeholders in render buffer #666

5HT opened this issue May 10, 2019 · 5 comments
Assignees
Labels
Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@5HT
Copy link

5HT commented May 10, 2019

Microsoft Windows [Version 10.0.18894.1000]

Reproduce. In both WSL and CMD consoles create files with UTF-8 in name or content. Try to display this content by using either MC or FAR. The character takes two placeholders in render buffer (unexpected), but it should take only one (expected). Here are some examples with RU language in UTF-8 (chcp 65001).

FAR:

Capture

MC:

Capture2

@zadjii-msft
Copy link
Member

@miniksa related to the other character sizing issues probably, yea?

#633 and maybe #455 seem similar

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues labels May 10, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 10, 2019
@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 10, 2019
@PhMajerus
Copy link

I don't think this is related to the issue I described in #455, I see random � being inserted between characters that are rendered fine on other lines, and can even appear and disappear when the zoom level is changed. So it's not the width for some specific characters that gets consistently assumed to be two columns.

@miniksa
Copy link
Member

miniksa commented May 13, 2019

I was trying to narrow down where the � are coming from prior to the Build conference and didn't finish. So I'll just hold onto these until I get a moment and try to track them all down (and any similarities/differences among them)

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@joe5saia
Copy link

I have a similar issue where terminal applications become misaligned vertically and � characters are occasionally drawn in place of a '─' character, (e.g. ─────���────). I notice it particularly with the application slack-term (https://github.com/erroneousboat/slack-term). The potentially interesting part is that closing and reopening slack-term will usually remove the � characters and properly render them as a line. When repeatedly opening and closing slack-term the � characters appear only occasionally, but when they do they appear, they appear in exactly the same location. I hope this information is useful.

@miniksa
Copy link
Member

miniksa commented Apr 22, 2020

image

Looking decent to me.

@miniksa miniksa closed this as completed Apr 22, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants