-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jemalloc] Generate cmake target files. #10243
Comments
@NancyLi1013 Hi. Any update on this? Would it be possible to do? |
Hi @ayermolo Thanks for posting this issue. |
I've seen this issue while trying to consume a couple of ports (the other being Is there vcpkg documentation on how to add this to a port. Are the folks who successfully add these target file exports just CMake sorcerers? |
Providing cmake config files ("[port]-targets.cmake, [port]-targets-debug.cmake, [port]-targets-release.cmake" etc.) should generally be done by, or requested from, the upstream software project (assuming it is using cmake). If cmake has a find module ("FindPort.cmake") and it doesn't work sufficiently for vcpkg, a port can install a file |
Interesting. Thank you for the explanation and example. I find that it greatly reduces the QoE of vcpkg when a package I want to consume needs more than a find_package and target_link_libraries call after adding it to a vcpkg.json. Do you think it would be sensible to add a test to the package CI builds? That way, over time, packages would require proper targets to pass the CI build before merge. |
@NickStrupat I don't want to make a general comment about testing in vcpkg. With regard to cmake config files, there is one related draft PR: #15173. |
For PR #15173, my goal is to test the properties of the generated targets to ensure that they can be used normally. |
@JackBoosY Close. jemalloc is not a cmake port so we shouldn't add this. |
I think we can make a jemalloc-config.cmake.in to do this. |
For other projects in share folder [port]-targets.cmake, [port]-targets-debug.cmake, [port]-targets-release.cmake are created. This allows for user projects that use vcpkgs ports to use find_package to link against instaled ports. For jemalloc these files are not generated. It would be very useful if this was enabled, and simplify cmake files on user side.
The text was updated successfully, but these errors were encountered: