Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the vcFormat.* settings defaults don't match VS default values #5907

Closed
sean-mcmanus opened this issue Aug 5, 2020 · 0 comments
Closed

Some of the vcFormat.* settings defaults don't match VS default values #5907

sean-mcmanus opened this issue Aug 5, 2020 · 0 comments
Assignees
@Colengms
Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone
1.0.0

Comments

@sean-mcmanus
Copy link
Collaborator

I noticed vcFormat.space.aroundAssignmentOperator and aroundBinaryOperator are defaulting to "ignore" instead of "insert". There might be more settings that don't match VS's defaults.
@sean-mcmanus sean-mcmanus added bug insiders Currently only repros with our latest Insiders release. Feature: Code Formatting Works in VS So we'd need to fix it for VS Code to reach parity. labels Aug 5, 2020
@sean-mcmanus sean-mcmanus added this to the 0.30.0 milestone Aug 5, 2020
@sean-mcmanus sean-mcmanus changed the title Some of the vcFormat.* settings don't match VS default values Some of the vcFormat.* settings defaults don't match VS default values Aug 5, 2020
@sean-mcmanus sean-mcmanus mentioned this issue Aug 5, 2020
Closed
@Colengms Colengms mentioned this issue Aug 11, 2020
Merged
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@sean-mcmanus @Colengms