Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using esbuild #7828

Closed
DonJayamanne opened this issue Oct 5, 2021 · 6 comments
Closed

Start using esbuild #7828

DonJayamanne opened this issue Oct 5, 2021 · 6 comments
Assignees
@DonJayamanne
Labels
debt Code quality issues

Comments

@DonJayamanne
Copy link
Contributor

No idea where the original issue went, i remember discussing this with the team as well.
Suggestion:

  • Use esbuild for the webview stuff (will be faster)
@rchiodo rchiodo added debt Code quality issues and removed issue_grooming_rich labels Oct 18, 2021
@rchiodo rchiodo self-assigned this Feb 2, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Feb 2, 2022

Going to try out esbuild. Start with ipywidgets.

@rchiodo rchiodo removed their assignment May 4, 2022
@rchiodo
Copy link
Contributor

rchiodo commented May 4, 2022

Gave up on this idea. There's a lot of stuff that esbuild doesn't support.

@rchiodo
Copy link
Contributor

rchiodo commented May 4, 2022

Biggest problem - dynamic requires. Jupyterlab does this in a bunch of spots.

@rchiodo
Copy link
Contributor

rchiodo commented May 4, 2022

evanw/esbuild#1921

@DonJayamanne DonJayamanne self-assigned this Aug 15, 2022
@DonJayamanne DonJayamanne mentioned this issue Oct 4, 2023
Merged
@DonJayamanne
Copy link
Contributor Author

All we now need is esbuild for the main bundle,
All of the following are done

  • IPyWidgets,
  • Renderers
  • Variable viewer
  • Plot viewer
  • DF viewer

@DonJayamanne
Copy link
Contributor Author

Closing this for now, as we have implemented this in all places except for the main bundles.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DonJayamanne @greazer @rchiodo