Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include green bars in "Open modified file" #4000

Closed
RikkiGibson opened this issue Sep 28, 2022 · 1 comment
Closed

Include green bars in "Open modified file" #4000

RikkiGibson opened this issue Sep 28, 2022 · 1 comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@RikkiGibson
Copy link
Member

  • Extension version: v0.50.0
  • VSCode Version: 1.71.2
  • OS: Not applicable

When reviewing a PR which makes large edits, it can be quite difficult to follow the lines added/removed, due to large gaps between lines in each respective view in the split view, or large interleaving of unrelated lines added/removed in the unified view.

image

Sometimes in these scenarios it is easier to ignore the lines removed and focus on the lines added. The "Open Modified File" command can be useful for this purpose. It even includes the PR comments on added lines (see the little message bubble glyphs on the left).

image

Unfortunately, the "modified file" lacks the green bars which indicate that a line was newly added in the PR. This means it's difficult to see the boundaries between unmodified code and added code. That means it's hard to tell what parts of the file we need to review. It looks like the "add comment" bar (the thicker gray bar on the left) somewhat indicates which lines were edited, but it is imprecise and difficult to see.

Similarly, it would also be handy if red bars would show up for deleted lines when using the "Open Original File" command. It looks like a similar situation, with comments on deleted lines showing up, etc.

It would be great to know if you have any sense of whether the team thinks this change would be worthwhile, and if so whether you would accept a contribution for it. Thanks!

@alexr00 alexr00 added the feature-request Request for new features or functionality label Sep 29, 2022
@alexr00
Copy link
Member

alexr00 commented Dec 9, 2022

Duplicate of #392

@alexr00 alexr00 marked this as a duplicate of #392 Dec 9, 2022
@alexr00 alexr00 closed this as completed Dec 9, 2022
@alexr00 alexr00 added *duplicate Issue identified as a duplicate of another issue(s) and removed duplicate labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants