Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@classmethod decorators not being properly treated #499

Closed
siftikha opened this issue Dec 30, 2017 · 2 comments · May be fixed by likern/vscode-python#4
Closed

@classmethod decorators not being properly treated #499

siftikha opened this issue Dec 30, 2017 · 2 comments · May be fixed by likern/vscode-python#4
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@siftikha
Copy link

siftikha commented Dec 30, 2017

Environment data

VS Code version: 1.19.0
Python Extension version:
Python Version: 3.6
OS and version: osx 10.13

I have a class defined as below

class A(object):
  @classmethod
  def load(cls, pk):
    pass
a = A()

Actual behavior

When I type a.load, cls is still expected as the first argument.

Expected behavior

I would expect that pk would be expected as the first argument.

Steps to reproduce:

Type the above

Logs

Not really applicable I wouldn't think.

I don't expect every decorator to be handled perfectly, but I would think that @classmethod is common enough that it should be handled properly.

@siftikha siftikha changed the title @Classmethod decorators not being properly treated @classmethod decorators not being properly treated Dec 30, 2017
@siftikha
Copy link
Author

siftikha commented Jan 1, 2018

This apparently is a known low priority issue davidhalter/jedi#498 in jedi

@DonJayamanne DonJayamanne added awaiting 1-decision area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality labels Jan 2, 2018
@brettcannon
Copy link
Member

Closing as this is an upstream issue which we don't have direct control or influence over.

@ghost ghost removed the needs upstream fix label Jul 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants