Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal API: On ready event #122471

Closed
Tyriar opened this issue Apr 27, 2021 · 2 comments
Closed

Terminal API: On ready event #122471

Tyriar opened this issue Apr 27, 2021 · 2 comments
Assignees
Labels
api api-proposal feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal Integrated terminal issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

I've heard from several extension authors that they want to know when a terminal is ready, this has historically been difficult to detect and I didn't want to commit to an API but I think something like the below would cover almost all these cases and it could not in the docs that it's not 100%.

// name could do with some work?
onDidReadyTerminal: Event<Terminal>;

This would be based on a heuristic for now, firing when:

  • Data has been written to the terminal, but no data within the last 250(?)ms
  • A maximum of 3(?)s has elapsed

We could then refine when this fires at a later point if we find a good way to detect this.

@Tyriar Tyriar added api terminal Integrated terminal issues api-proposal labels Apr 27, 2021
@Tyriar Tyriar added this to the Backlog milestone Apr 27, 2021
@Tyriar Tyriar self-assigned this Apr 27, 2021
@Tyriar Tyriar added the feature-request Request for new features or functionality label Oct 8, 2021
@connor4312
Copy link
Member

I think this duplicates #127717

@Tyriar
Copy link
Member Author

Tyriar commented Oct 18, 2021

Not quite, on ready was meant to mean the terminal has finished initializing where we would use insights like from shell integration to know the prompt was ready to go. But there seems to be little interest in it.

@Tyriar Tyriar closed this as completed Oct 18, 2021
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api api-proposal feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants