Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout menu appears in wrong location #141388

Closed
bpasero opened this issue Jan 25, 2022 · 2 comments · Fixed by #143656
Closed

Layout menu appears in wrong location #141388

bpasero opened this issue Jan 25, 2022 · 2 comments · Fixed by #143656
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 25, 2022

Testing #141357

With the window split in half:
Recording 2022-01-25 at 11 44 09

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues labels Jan 25, 2022
@sbatten sbatten added this to the January 2022 milestone Jan 25, 2022
@sbatten
Copy link
Member

sbatten commented Jan 28, 2022

This one is pretty weird. I need to revisit next milestone unless I come up with a fix I'm less worried about. The summary is that native menus with dropdowns calculate x and y accounting for the zoom level. In this case, the zoom level doesn't need to apply because the title bar is special cased to not be zoomed like the rest of the window. So, if you have any zoom level, we miscalculate. Unfortunately this knowledge isn't shared down the line, so I have to come up with something to handle it in all cases and I don't want to risk breaking all the other dropdowns.

@sbatten
Copy link
Member

sbatten commented Feb 23, 2022

cc @misolori

@bpasero bpasero added the verified Verification succeeded label Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bpasero @sbatten and others