Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Extension host fails to initialize when certain browser extensions are installed #142485

Closed
joaomoreno opened this issue Feb 8, 2022 · 4 comments
Closed

Web: Extension host fails to initialize when certain browser extensions are installed #142485

joaomoreno opened this issue Feb 8, 2022 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded vscode.dev Issues related to vscode.dev web Issues related to running VSCode in the web
Milestone
January 2022 Reco...

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 8, 2022 •
edited
Loading

The root cause is that the init message first sent to an extension host worker might be preceded with messagse sent by various browser extensions, since they have access to the DOM and can (and will) freely call postMessage on iframes they find.
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release web Issues related to running VSCode in the web vscode.dev Issues related to vscode.dev labels Feb 8, 2022
@joaomoreno joaomoreno added this to the January 2022 Recovery 2 milestone Feb 8, 2022
@joaomoreno joaomoreno self-assigned this Feb 8, 2022
@joaomoreno
Copy link
Member Author

Fixed by 2e9ed43

@joaomoreno
Copy link
Member Author

joaomoreno commented Feb 8, 2022 •
edited
Loading

Verification: please use Chrome/Edge

  1. Install the Stylebot browser extension
  2. Open https://vscode.dev/?vscode-version=443ac033e56d0477ede52b0d25c06ad6d4e59ad4
  3. Try to open a GitHub repository

Auth should work successfully.

@joaomoreno joaomoreno mentioned this issue Feb 8, 2022
Merged
@joaomoreno
Copy link
Member Author

joaomoreno commented Feb 8, 2022 •
edited
Loading

Speculations on why Stylebot breaks it:

@isidorn isidorn added the verified Verification succeeded label Feb 9, 2022
@joyceerhl joyceerhl mentioned this issue Feb 11, 2022
Closed
@alexdima
Copy link
Member

Anyway the two editors could interfere, @alexdima?

Who knows 🤷 . The standalone editor doesn't ship a web worker extension host, so my best guess is that an unexpected postMessage was causing this.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded vscode.dev Issues related to vscode.dev web Issues related to running VSCode in the web
Projects
None yet
Milestone
January 2022 Recovery 2
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @alexdima