Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show multi-line paste warning when bracketed paste mode is enabled #142525

Closed
Tyriar opened this issue Feb 8, 2022 · 2 comments
Closed

Don't show multi-line paste warning when bracketed paste mode is enabled #142525

Tyriar opened this issue Feb 8, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 8, 2022

See #122683 (comment)

We have modes exposed in xterm.js now, need to check this prop: https://github.com/xtermjs/xterm.js/blob/a13f11adb4b04245684b24a5b33cbbc2351588d4/typings/xterm.d.ts#L1701-L1704
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. labels Feb 8, 2022
@Tyriar Tyriar added this to the February 2022 milestone Feb 8, 2022
@Tyriar Tyriar mentioned this issue Feb 8, 2022
Closed
@Tyriar Tyriar closed this as completed in 46f952f Feb 14, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 24, 2022 •
edited
Loading

What are some verification steps for this issue?

@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Feb 25, 2022
@meganrogge
Copy link
Contributor

meganrogge commented Feb 25, 2022 •
edited
Loading

In bash (might be different for other shells), run printf "\e[?2004h" in the terminal. You'll know it's on because you'll see some strange characters like 01~ in the terminal.

Copy and paste some multiline text.

You shouldn't see the warning.

To disable it, run printf "\e[?2004l"
Copy and paste multiline text. You should see the warning.

@meganrogge meganrogge removed the verification-steps-needed Steps to verify are needed for verification label Feb 25, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@Tyriar @rzhao271 @meganrogge and others