Test folder / directory names in file associations

[aeschli]

Refs: #136656

• anyOS @IanMatthewHuff
• anyOS @hediet

Complexity: 3

Create Issue

---

In file icon themes, the associations in folderNames, folderNamesExpanded, fileNames and fileExtensions can now also contain a folder name:

  "fileNames": {
    "system/win.ini": "_win_ini_file"
  },

system/win.ini means that the association matches files called win.ini directly in a folder system

  "fileExtensions": {
    "system/ini": "_ini_file"
  },

system/ini means that the association matches files called *.ini directly in a folder system

  "folderNames": {
    ".vscode/extensions": "_vscode_folder"
  },

Test this by creating a file icon theme and trying various rules

• create a new extension with yo code
• copy the icons folder of the seti theme in the new extemsion
• add to the package.json

  "contributes": {
    "iconThemes": [
      {
        "id": "vs-seti-plus",
        "label": "Seti Plus",
        "path": "./icons/vs-seti-icon-theme.json"
      }
    ]
  }

• Add new rules in vs-seti-icon-theme.json

To test:

• folder/name is stronger than just name
• folder/extension is stronger that extension, but loses to name

[hediet]

Nice work on the feature!
It is cool that the theme.json file supports hot reload!

[IanMatthewHuff]

Awesome this seems really helpful. Handled everything that I tossed at it, though @aeschli I did have two quick questions. I initially expected that I might be able to specify multiple folders like FolderA\FolderB\filename this doesn't work, but looking at the test plan I believe that this is expected to only be a single folder, so I didn't file an issue here. For kicks I also tried with ~ as a folder for my home directory. This also didn't work, but might be expected.

• fileNames + folder
• fileExtensions + folder
• folderNames + folder
• folderNamesExpanded + folder
• folder/name beats name
• folder/extension beats extension loses to name
• multiple folders deep (on rereading the item not expected to work?)
• ~ folder
• Odd folder names (special characters ect...)

[aeschli]

@hediet @IanMatthewHuff Thanks for testing.

Yes, it's only one folder, the direct parent. That fit well with the current implementation. More sophisticated associations like glob pattern would require a rewrite.

[ghost]

I did mention . as alias for workspace root dir. I think it might require a different CSS selector in the implementation.