Refresh Explorer is broken when Activity Bar Position Hidden

[dacapoday]

Steps to Reproduce:

1. Enable a Plugin that contribute status bar button

2. Select the Activity Bar Position as Hidden
   

3. Click Refresh Explorer

Then:

Version: 1.84.0
Commit: d037ac0
Date: 2023-11-01T11:29:04.398Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.84.0 Chrome/114.0.5735.289 Electron/25.9.2 Safari/537.36

[dacapoday]

Probably depends on #118692

[gjsjohnmurray]

Probably #197169

[sandy081]

May not be #197169.

@dacapoday What do you mean by Refresh Explorer is broken? Can you please elaborate what is not working?

[dacapoday]

May not be #197169.

@dacapoday What do you mean by Refresh Explorer is broken? Can you please elaborate what is not working?

As shown in the screenshot, after hiding Activity Bar, click Refresh Explorer. Folders disappears, Only empty view shown.
But I expected that the folders should not change (disk or remote host has not changed).

I can reproduce this behavior on both the local folder and Remote SSH.

[gjsjohnmurray]

May not be #197169

Agreed. I haven't been able to repro a problem with Refresh Explorer resulting in a blank tree, no matter whether Activity Bar is hidden or not.

[dacapoday]

May not be #197169

Agreed. I haven't been able to repro a problem with Refresh Explorer resulting in a blank tree, no matter whether Activity Bar is hidden or not.

[gjsjohnmurray]

@dacapoday does this repro for you after you run the command to reload with all extensions disabled?

[dacapoday]

@dacapoday does this repro for you after you run the command to reload with all extensions disabled?

Oh, sorry. Need a Plugin that contribute status bar button to reproduce.

The Plugin in the screenshoot is very simple, only create two status bar button.

[gjsjohnmurray]

@dacapoday are you able to repro it with https://github.com/microsoft/vscode-extension-samples/tree/main/statusbar-sample?

[dacapoday]

@dacapoday are you able to repro it with https://github.com/microsoft/vscode-extension-samples/tree/main/statusbar-sample?

Yes,

use case:
status-ts-0.0.1.zip

[sandy081]

What is this Selected Line Numbers extension? Can you please provide us steps to reproduce? Also provide the source code of the sample extension that is causing this issue.

[dacapoday]

What is this Selected Line Numbers extension? Can you please provide us steps to reproduce? Also provide the source code of the sample extension that is causing this issue.

This extension is compiled from the source code of https://github.com/microsoft/vscode-extension-samples/tree/main/statusbar-sample mentioned by @gjsjohnmurray, I only modified the package.json publisher for local installation.

You can directly unzip the extension by zip. vsix is just a zip file. It already contains the source code.

[dacapoday]

By the way, for Version 1.84.2

[sandy081]

Do you see any errors in the following places?

• F1 > Toggle Developer Tools > Console
• F1 > Open View... > Window

[dacapoday]

Do you see any errors in the following places?

• F1 > Toggle Developer Tools > Console
• F1 > Open View... > Window

No, during the operation, no new logs are generated.

[dacapoday]

I'm not familiar with VSCode's code, but could it be related to Explorer and Folders alteration:
Historically, I've tried to use Secondary Side Bar to achieve the effect of #118692, but failed because #143264.
Later, #173619 modifies the relationship between Explorer and Folders.

[sandy081]

Unfortunately I cannot reproduce it with the statusbar-sample extension. The last thing I would try is to start VS Code using fresh user data and extensions directories and check. You can do this from CLI
code --user-data-dir <folder1> --extensions-dir <folder-2>

[VSCodeTriageBot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!