Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Expose folding regions through executeFoldingRangeProvider #36638

Closed
patrys opened this issue Oct 20, 2017 · 8 comments · Fixed by #172968
Closed

[folding] Expose folding regions through executeFoldingRangeProvider #36638

patrys opened this issue Oct 20, 2017 · 8 comments · Fixed by #172968
Assignees
Labels
api feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@patrys
Copy link

patrys commented Oct 20, 2017

I maintain a code structure visualizing plugin (Code Outline) that would benefit from having access to the named regions introduced in one of the recent versions (see related issue).

@vscodebot vscodebot bot added the api label Oct 20, 2017
@aeschli aeschli added the feature-request Request for new features or functionality label Oct 23, 2017
@aeschli aeschli added this to the Backlog milestone Oct 23, 2017
@aeschli aeschli changed the title Expose folding regions in API [folding] Expose folding regions in API Dec 1, 2017
@patrys
Copy link
Author

patrys commented May 8, 2018

Now that the folding API is stable, could we get an executeFoldingRangeProvider extended command?

@aeschli
Copy link
Contributor

aeschli commented May 8, 2018

@patrys Will look into it ASAP

@SimonSiefke
Copy link
Contributor

This would also be useful for testing folding ranges with vscode-test.

@octref
Copy link
Contributor

octref commented Aug 28, 2020

Ping @aeschli, would want this to do E2E test for language servers.

@ihdavids
Copy link

Determining which rows are currently folded or being able to test if a region is currently folded would be a huge benefit to some plugins.

@aeschli aeschli changed the title [folding] Expose folding regions in API [folding] Expose folding regions through executeFoldingRangeProvider Aug 26, 2022
@aeschli aeschli modified the milestones: Backlog, September 2022 Aug 26, 2022
@aeschli aeschli modified the milestones: September 2022, October 2022 Sep 26, 2022
@aeschli aeschli modified the milestones: October 2022, November 2022 Oct 23, 2022
@allisonchou
Copy link
Member

@aeschli is there an ETA for this work? This would be very helpful for the Razor team.

@aeschli aeschli modified the milestones: November 2022, On Deck Nov 28, 2022
@joaomoreno joaomoreno modified the milestones: On Deck, February 2023 Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 1, 2023
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2023

There's now a command vscode.executeFoldingRangeProvider returning the folding ranges from providers or from the default provider (indentation based). Ranges are sanitized (duplicates and overlapping ranges removed) and follows the settings editor.folding, editor.foldingStrategy and editor.defaultFoldingRangeProvider

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
@aeschli aeschli added the verification-needed Verification of issue is requested label Feb 20, 2023
@jrieken jrieken added the verified Verification succeeded label Feb 21, 2023
@jrieken
Copy link
Member

jrieken commented Feb 21, 2023

verified in source code

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants