Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While doing a search and replace in project, there is no way to open the original file #56139

Closed
zinkkrysty opened this issue Aug 10, 2018 · 2 comments
Closed

While doing a search and replace in project, there is no way to open the original file #56139

zinkkrysty opened this issue Aug 10, 2018 · 2 comments
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@zinkkrysty
Copy link

  • VSCode Version: 1.25.1
  • OS Version: MacOS 10.13.6

Steps to Reproduce:

  1. Do a search in project (⇧⌘F)
  2. Fill in the Replace field
  3. Clicking on any file or line in the sidebar opens up a read-only diff view, with no possibility of opening the original file (no right click context menu, no icon shortcut)

image

Expected outcome:
A way to open the file. Similar to using the Source Control sidebar (where there is an image "Open File" icon button for each modified file).
image

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the search Search widget and operation issues label Aug 10, 2018
@roblourens roblourens added the feature-request Request for new features or functionality label Aug 10, 2018
@roblourens
Copy link
Member

I don't know if there should be a button on every row (it takes up space for the preview) but there should at least be an editor action for it (bar at the top of the editor)

@roblourens
Copy link
Member

Dupe of #35337

@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) and removed feature-request Request for new features or functionality labels Sep 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @zinkkrysty