Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task property "presentation": {"reveal": "never"} is not working when Python extension is active #66056

Closed
d3r3kk opened this issue Jan 4, 2019 · 2 comments
Assignees
Labels
tasks Task system issues

Comments

@d3r3kk
Copy link

d3r3kk commented Jan 4, 2019

@jcrmatos commented on Thu Jan 03 2019

Environment data

  • VS Code version: 1.30.1
  • Extension version (available under the Extensions sidebar): 2018.12.1
  • OS and version: Windows 7 Pro SP1 + all updates
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7.1 (WinPython)
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv created by pipenv

Expected behaviour

Task property "presentation": {"reveal": "never"} should never show the terminal panel when the task runs.

Actual behaviour

Task property "presentation": {"reveal": "never"} always shows the terminal panel when the task runs and the Python extension is active.

Steps to reproduce:

  1. Activate the Python extension.
  2. Create a task, eg.
        {
            "label": "Py3 Help",
            "type": "shell",
            "windows": {
                "command": "${env:OneDrive}\\Python\\winpython371-32\\python-3.7.1\\Doc\\python371.chm"
            },
            "presentation": {
                "reveal": "never"
            }
        },
  1. Create a keyboard shortcut, eg.
[{
    "key": "shift+f1",
    "command": "workbench.action.tasks.runTask",
    "args": "Py3 Help"
}]
  1. Run the task, in my eg. shift+F1

Output in terminal (that should not appear)

> Executing task in folder uniclave: C:\Users\JMatos\OneDrive\Python\winpython371-32\python-3.7.1\Doc\python371.chm <


Terminal will be reused by tasks, press any key to close it.

I created a simple Task and added the presentation item, hoping that that would allow me to never show the integrated terminal (as it is reported in the doc at
https://code.visualstudio.com/docs/editor/tasks#vscode
but it isn't working. It always shows the integrated terminal.

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Py3 Help",
            "type": "shell",
            "command": "C:\\Python354-32\\Doc\\python354.chm",
            "problemMatcher": [],
            "presentation": {
                "reveal": "never"
            }
        }
    ]
}

Thanks,

JM

@vscodebot
Copy link

vscodebot bot commented Jan 4, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the tasks Task system issues label Jan 4, 2019
@d3r3kk
Copy link
Author

d3r3kk commented Jan 4, 2019

Is indeed the same as #65179

@d3r3kk d3r3kk closed this as completed Jan 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants