Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to file from replace preview #68610

Closed
MathiasKandelborg opened this issue Feb 13, 2019 · 5 comments
Closed

Go to file from replace preview #68610

MathiasKandelborg opened this issue Feb 13, 2019 · 5 comments
Assignees
Labels
search Search widget and operation issues

Comments

@MathiasKandelborg
Copy link

I have been using the search functionality quite a lot lately, it works great! I often have to search twice when looking for a keyword: once in search and once to look up the file. In my perception, this functionality has changed over the past few months. I think I remember searching keywords and then accessing the files directly from search - although, I might have been 'lucky' and had the files open every time I searched in the past.

Possible solutions:

  1. Right clicking the file has a 'go to file /open in editor'
  2. Double clicking the file opens the file
  3. Keyboard command that opens the file when in 'Replace Preview'
  • A combination of 1 or 2 & 3
@vscodebot
Copy link

vscodebot bot commented Feb 13, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the search Search widget and operation issues label Feb 13, 2019
@MathiasKandelborg
Copy link
Author

I've tinkered a bit and quickly found that files open normally when there are no characters in the replace field. I think this is quite unintuitive, but something I'll remember for now.

@roblourens
Copy link
Member

Thought there was an issue to add a button to open the file directly from the replace preview, but I can't find it. You can disable the replace preview, if that helps. "search.useReplacePreview": false

@roblourens roblourens added the feature-request Request for new features or functionality label Feb 17, 2019
@roblourens roblourens changed the title Access files when using search Go to file from replace preview Feb 17, 2019
@MathiasKandelborg
Copy link
Author

Nice with the disable option, I'm gonna use that. Thanks for the help.

I think the default should be reversed, that would make more sense when beginning to customize - maybe it needs some guide or something along those lines... Because I'd never think that my text-editor had a replace view unless I've specifically added/enabled it.

There might be reasoning behind the current default which I'm not aware of - I'm basically just sharing my thoughts on the subject 🙂

@roblourens roblourens added the help wanted Issues identified as good community contribution opportunities label Oct 9, 2019
@roblourens
Copy link
Member

Dupe of #35337

@roblourens roblourens removed feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Oct 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants