Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testhost should use the apphost sdk feature #2101

Closed
ViktorHofer opened this issue Jul 19, 2019 · 0 comments
Closed

Testhost should use the apphost sdk feature #2101

ViktorHofer opened this issue Jul 19, 2019 · 0 comments
Assignees

Comments

@ViktorHofer
Copy link
Member

testhost.dll should use the apphost sdk feature to crate a native executable testhost.exe which finds the right host itself without using the PATH environment variable. This native executable should be invoked instead of the testhost.dll. This would also solve the problem with looking up the right host for x86 vs x64.

This helps dotnet repositories like corefx to use VSTest and VS Test Explorer as the native executable honors environment variables like DOTNET_ROOT which can be used to point to the right host.

One concern from @vitek-karas was that the apphost feature isn't backwards compatible.

cc @mayankbansal018 @cltshivash @singhsarab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants