Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass coverlet codebase in runsettings for inproc data collector initialization #2275

Closed
vagisha-nidhi opened this issue Dec 17, 2019 · 2 comments · Fixed by #2288
Closed
Assignees

Comments

@vagisha-nidhi
Copy link
Contributor

vagisha-nidhi commented Dec 17, 2019

Description

Initilization of inproc coverlet collector today needs passing the datacollector extensibility in TestPluginCache. This enables the InProcDataCollectionExtensionManager to be able to find the datacollector in all datacollector extension paths if inproc datacollector codebase path is not an absolute path.
We should directly add this path in runsettings ideally since vstest.console.exe is aware of all datacollector extension paths.
This will remove unnecessary coverlet specific changes from

extensions = extensions.Concat(TestPluginCache.Instance.GetExtensionPaths(ProxyExecutionManager.CoverletDataCollector, true)).ToList();
and
https://github.com/microsoft/vstest/blob/master/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs#L321

cc: @AbhitejJohn @MarcoRossignoli

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Dec 29, 2019

I'm working on this, I'll let you know.
I found also a new small bug, I'll open new issue.
Feel free to assign to me if you want.

@vagisha-nidhi
Copy link
Contributor Author

Thanks @MarcoRossignoli 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants