Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate codebase paths #2979

Closed
KirillOsenkov opened this issue Jul 10, 2021 · 0 comments
Closed

Deduplicate codebase paths #2979

KirillOsenkov opened this issue Jul 10, 2021 · 0 comments
Assignees
@engyebrahim
Labels
enhancement triaged

Comments

@KirillOsenkov
Copy link
Member

KirillOsenkov commented Jul 10, 2021 •
edited by testplatform-bot
Loading

Need to deduplicate codebase paths here (probably just use a HashSet with OrdinalIgnoreCase):

vstest/src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs

Line 66 in 92f2100

this.codeBasePaths = new List<string> { this.defaultCodeBase };

Otherwise you get stuff like this:
image

AB#1582732
@Evangelink Evangelink added needs-triage This item should be discussed in the next triage meeting. enhancement triaged and removed needs-triage This item should be discussed in the next triage meeting. labels Jul 26, 2022
@engyebrahim engyebrahim mentioned this issue Jul 28, 2022
Merged
@pavelhorak pavelhorak removed the sprint label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engyebrahim engyebrahim

Labels
enhancement triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KirillOsenkov @Evangelink @pavelhorak @engyebrahim