Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing calls to BuildMultipleAssemblyPath when passing only one source #3510

Closed
Evangelink opened this issue Mar 24, 2022 · 2 comments · Fixed by #4358
Closed

Consider replacing calls to BuildMultipleAssemblyPath when passing only one source #3510

Evangelink opened this issue Mar 24, 2022 · 2 comments · Fixed by #4358
Labels
engineering up-for-grabs

Comments

@Evangelink
Copy link
Member

There is no need to use BuildMultipleAssemblyPath if we pass only one source, instead we could use GetASsetFullPath.

Originally posted by @Evangelink in #3459 (comment)
@daveMueller
Copy link
Contributor

Is it OK if I work on this and contribute a PR?

@daveMueller daveMueller mentioned this issue Apr 1, 2023
Merged
@nohwnd
Copy link
Member

nohwnd commented Apr 4, 2023

Thanks @daveMueller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering up-for-grabs
Projects
None yet
Milestone
No milestone
3 participants
@nohwnd @Evangelink @daveMueller