Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid API set names in metadata #92

Closed
kennykerr opened this issue Jan 11, 2021 · 2 comments
Closed

Avoid API set names in metadata #92

kennykerr opened this issue Jan 11, 2021 · 2 comments
Labels
broken api An API is inaccurate and could lead to runtime failure

Comments

@kennykerr
Copy link
Contributor

The doc says this function is exported from urlmon.dll but the metadata says ext-ms-win-core-iuri-l1-1-0. Even if that works up-level, we should prefer the original DLL names as that provides compatibility down-level and "just works" everywhere.
@AArnott AArnott added the broken api An API is inaccurate and could lead to runtime failure label Jan 14, 2021
@kennykerr kennykerr changed the title Windows.Win32.Com.Apis.CreateUri DLL Avoid API set names in metadata Jan 22, 2021
@kennykerr kennykerr mentioned this issue Jan 22, 2021
Closed
@kennykerr kennykerr mentioned this issue Jan 31, 2021
Closed
@DaLynX
Copy link

DaLynX commented Feb 1, 2021

I am having the same issue with MiniDumpWriteDump which is in DbgHelp.dll and documented as such but gets linked with api-ms-win-core-debug-minidump-l1-1-0.dll.

@sotteson1
Copy link
Contributor

The scraper is trying to use the non-api set whenever it exists. It looks like both of these methods have been fixed by that change. Let me know if you see others you think shouldn't be using an api set.

@kennykerr kennykerr mentioned this issue Nov 4, 2021
Closed
@ChrisDenton ChrisDenton mentioned this issue Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken api An API is inaccurate and could lead to runtime failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AArnott @kennykerr @DaLynX @sotteson1