Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containment for catalogs/accessPackages #338

Closed
peombwa opened this issue Apr 28, 2023 · 0 comments · Fixed by #341
Closed

Remove containment for catalogs/accessPackages #338

peombwa opened this issue Apr 28, 2023 · 0 comments · Fixed by #341
Assignees

Comments

@peombwa
Copy link
Member

peombwa commented Apr 28, 2023

Containment on catalogs/accessPackages should be removed since requests made to POST /identityGovernance/entitlementManagement/catalogs/{accessPackageCatalog-id}/accessPackages/{accessPackage-id}/assignmentPolicies fail with No HTTP resource was found that matches the request URI 'https://igaelm-asev3-ecapi-neu.igaelm-asev3-environment-neu.p.azurewebsites.net/api/v1/catalogs('id')/accessPackages('id)/assignmentPolicies'. error message.

The error message suggests that the workload does not support path. Unfortunately, the path is currently surfaced as supported in the CSDL which leads to the overgeneration seen at microsoftgraph/msgraph-sdk-powershell#1970:

CSDL

<EntityType Name="accessPackageCatalog" BaseType="graph.entity">
  <Property Name="catalogType" Type="graph.accessPackageCatalogType" />
  <Property Name="createdDateTime" Type="Edm.DateTimeOffset" />
  <Property Name="description" Type="Edm.String" />
  <Property Name="displayName" Type="Edm.String" />
  <Property Name="isExternallyVisible" Type="Edm.Boolean" />
  <Property Name="modifiedDateTime" Type="Edm.DateTimeOffset" />
  <Property Name="state" Type="graph.accessPackageCatalogState" />
  <NavigationProperty Name="accessPackages" Type="Collection(graph.accessPackage)" ContainsTarget="true" /> <!--Should not be contained-->
</EntityType>

OpenAPI

  '/identityGovernance/entitlementManagement/catalogs/{accessPackageCatalog-id}/accessPackages/{accessPackage-id}/assignmentPolicies':
    post:
      summary: Create new navigation property to assignmentPolicies for identityGovernance
      operationId: identityGovernance.entitlementManagement.catalogs.accessPackages_CreateAssignmentPolicies
      ...
    get:
      summary: Get assignmentPolicies from identityGovernance
      operationId: identityGovernance.entitlementManagement.catalogs.accessPackages_ListAssignmentPolicies
      ...

As per the API reference - https://learn.microsoft.com/en-us/graph/api/resources/accesspackagecatalog?view=graph-rest-1.0#relationships:

Relationship Type Description
accessPackages accessPackage collection The access packages in this catalog. Read-only. Nullable.

Additional Notes

Workload owner's input is needed to validate the above assumption.

The issue is closely related to #243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants