Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger: Make close of migrationSpan more robust if planning to turn on by default in user envs. #1023

Open
djwhatle opened this issue Mar 25, 2021 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@djwhatle
Copy link
Contributor

See #967 (comment)

Closing the final Jaeger span for a migration can cause problems if any other spans are open at the time. A naive solution I wrote waits 5 minutes after the migmigration completes to close the span, giving any ongoing reconciles 5 minutes to return. I think this will cover 99.9% of cases but if we deploy this as something other than a dev tool we should consider making this close action more robust and not allowing any subsequent child span writes.

@djwhatle djwhatle added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2021
@djwhatle djwhatle mentioned this issue Mar 25, 2021
5 tasks
@djwhatle djwhatle changed the title Make close of migrationSpan more robust if planning to turn on by default in user envs. Jaeger: Make close of migrationSpan more robust if planning to turn on by default in user envs. Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant