Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor duplicate imports, lateral package imports #1095

Open
pranavgaikwad opened this issue Apr 29, 2021 · 1 comment
Open

Refactor duplicate imports, lateral package imports #1095

pranavgaikwad opened this issue Apr 29, 2021 · 1 comment
Assignees
@pranavgaikwad
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@pranavgaikwad
Copy link
Contributor

Describe the bug
This is created to track refactoring effort involving removing mainly the lateral controller imports wherever found. Side objective is to also remove duplicate condition types and move whatever is commonly used to the apis package.

For example, see this:
https://github.com/konveyor/mig-controller/blob/157b004642397bca3d25af4d0f8de14ae28610d2/pkg/controller/migmigration/dvm.go#L14

https://github.com/konveyor/mig-controller/blob/157b004642397bca3d25af4d0f8de14ae28610d2/pkg/controller/migplan/validation.go#L13
@pranavgaikwad pranavgaikwad added the kind/bug Categorizes issue or PR as related to a bug. label Apr 29, 2021
@djwhatle
Copy link
Contributor

+1

@pranavgaikwad pranavgaikwad self-assigned this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranavgaikwad pranavgaikwad

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djwhatle @pranavgaikwad