Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapo-py 0.3.1 code hangs on timeout #245

Open
mihai-dinculescu opened this issue Jul 14, 2024 · 3 comments
Open

tapo-py 0.3.1 code hangs on timeout #245

mihai-dinculescu opened this issue Jul 14, 2024 · 3 comments

Comments

@mihai-dinculescu
Copy link
Owner

mihai-dinculescu commented Jul 14, 2024

Two users (c91ee35#commitcomment-144217052 & #228 (comment)) have reported that after the migration to pyo3 0.21, the code hangs when timeouts occur.

I have been able to reproduce the problem, and it seems that the hangs are caused by the isahc's send_async future that never completes. Using the non-async send function works as intended.

However, I'd like to explore migrating away from isahc, as it no longer seems to be well maintained.

@mihai-dinculescu mihai-dinculescu changed the title tapo-py 0.3.1 tapo-py 0.3.1 code hangs Jul 14, 2024
@mihai-dinculescu mihai-dinculescu changed the title tapo-py 0.3.1 code hangs tapo-py 0.3.1 code hangs on timeout Jul 14, 2024
@TTSKarlsson
Copy link

Is there a workaround for now, like choosing a version that works? If so how do I use it?

@avadiax
Copy link

avadiax commented Aug 26, 2024

Hi, I noticed you have released 0.3.2. The timeout issue still continue to persist and I have continued to use 0.3.0. FYI.

@mihai-dinculescu
Copy link
Owner Author

@TTSKarlsson v0.3.0 is the latest good version that doesn't exhibit this issue.
@avadiax, the fix for this proved more difficult than I thought, and I'm still exploring what's the best way to address the issue. Please bear with me 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants