From 462ef5c2a95b469a38da2753cace1a8a692e9171 Mon Sep 17 00:00:00 2001 From: paytonward6 <72841140+paytonward6@users.noreply.github.com> Date: Thu, 28 Dec 2023 20:55:21 -0600 Subject: [PATCH 1/2] Add cert_check kwarg to Minio class docs --- docs/API.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/API.md b/docs/API.md index f34b7f74..3a7d6b1b 100644 --- a/docs/API.md +++ b/docs/API.md @@ -17,6 +17,7 @@ __Parameters__ | `region` | _str_ | (Optional) Region name of buckets in S3 service. | | `http_client` | _urllib3.poolmanager.PoolManager_ | (Optional) Customized HTTP client. | | `credentials` | _minio.credentials.Provider_ | (Optional) Credentials provider of your account in S3 service. | +| `cert_check` | _bool_ | (Optional) Flag to indicate if SSL certificate of S3 endpoint should verified. | **NOTE on concurrent usage:** `Minio` object is thread safe when using the Python `threading` library. Specifically, it is **NOT** safe to share it between multiple processes, for example when using `multiprocessing.Pool`. The solution is simply to create a new `Minio` object in each process, and not share it between processes. From 0954f3c638a3cfa16c4e391350ed92b6df8a3167 Mon Sep 17 00:00:00 2001 From: paytonward6 <72841140+paytonward6@users.noreply.github.com> Date: Fri, 29 Dec 2023 10:38:20 -0600 Subject: [PATCH 2/2] Update description for cert_check flag --- docs/API.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/API.md b/docs/API.md index 3a7d6b1b..d069e392 100644 --- a/docs/API.md +++ b/docs/API.md @@ -17,7 +17,7 @@ __Parameters__ | `region` | _str_ | (Optional) Region name of buckets in S3 service. | | `http_client` | _urllib3.poolmanager.PoolManager_ | (Optional) Customized HTTP client. | | `credentials` | _minio.credentials.Provider_ | (Optional) Credentials provider of your account in S3 service. | -| `cert_check` | _bool_ | (Optional) Flag to indicate if SSL certificate of S3 endpoint should verified. | +| `cert_check` | _bool_ | (Optional) Flag to check on server certificate for HTTPS connection. | **NOTE on concurrent usage:** `Minio` object is thread safe when using the Python `threading` library. Specifically, it is **NOT** safe to share it between multiple processes, for example when using `multiprocessing.Pool`. The solution is simply to create a new `Minio` object in each process, and not share it between processes.