Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cohttp 5.3.0: Cookie.Set_cookie_hdr.extract only work with lower case set-cookie and not uppercase Set-Cookie #1007

Closed
chomosuke opened this issue Nov 20, 2023 · 2 comments
Labels

Comments

@chomosuke
Copy link

chomosuke commented Nov 20, 2023

My work around is:

    let header =
      Header.add_multi header "set-cookie" @@ Header.get_multi header "Set-Cookie"
    in

I noticed that this has already been fixed in master with Http.Header.Private.caseless_equal but it'll be nice if the fix can be backported.

Thank you :)

@mseri mseri added the Bug label Nov 20, 2023
@mseri
Copy link
Collaborator

mseri commented Nov 20, 2023

Thanks. If you send a PR against the https://github.com/mirage/ocaml-cohttp/tree/v5-backports branch, I'd be happy to review it and eventually prepare a bugfix release

@mseri
Copy link
Collaborator

mseri commented Dec 13, 2023

Thanks for the PR and sorry for the delay, I have submitted the release: ocaml/opam-repository#24936

@mseri mseri closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants