Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests use a non-existent Router#setOrthogonalNudgeDistance method #35

Open
VsevolodGolovanov opened this issue Jan 24, 2019 · 1 comment
Open

Tests use a non-existent Router#setOrthogonalNudgeDistance method #35

VsevolodGolovanov opened this issue Jan 24, 2019 · 1 comment

Comments

@VsevolodGolovanov
Copy link

VsevolodGolovanov commented Jan 24, 2019 •
edited
Loading

Some tests such as corneroverlap01 refer to a non-existent method:
Error C2039 'setOrthogonalNudgeDistance': is not a member of 'Avoid::Router' corneroverlap01 D:\work\adaptagrams-master[2019-01-24]\cola\libavoid\tests\corneroverlap01.cpp 12
The method was deleted in 2012 apparently: c64d677.
@VsevolodGolovanov
Copy link
Author

VsevolodGolovanov commented Jan 24, 2019 •
edited
Loading

I don't want to sound entitled, but such severe code debt doesn't inspire confidence in the library.

Update: eh, I guess these tests are disabled in the makefile. I tried building it via MSVC, which seems to be an afterthought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VsevolodGolovanov