From 412dbcd056d70f18fb06889e85377a5a83020ad4 Mon Sep 17 00:00:00 2001 From: Michal Maslanka Date: Tue, 24 May 2022 11:12:48 +0200 Subject: [PATCH] k/group: do not serialize key iobuf as iobuf When serialized a key is already an iobuf. Wrapping it with another serialization layer is incorrect as it introduces additional size field in the binary format that deserializer doesn't expect. Signed-off-by: Michal Maslanka --- src/v/kafka/server/group.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/v/kafka/server/group.cc b/src/v/kafka/server/group.cc index f46558635c04..d50e117c5627 100644 --- a/src/v/kafka/server/group.cc +++ b/src/v/kafka/server/group.cc @@ -2393,7 +2393,7 @@ void add_offset_tombstone_record( .partition = tp.partition, }; auto kv = serializer.to_kv(offset_metadata_kv{.key = std::move(key)}); - builder.add_raw_kv(reflection::to_iobuf(std::move(kv.key)), std::nullopt); + builder.add_raw_kv(std::move(kv.key), std::nullopt); } void add_group_tombstone_record( @@ -2404,7 +2404,7 @@ void add_group_tombstone_record( .group_id = group, }; auto kv = serializer.to_kv(group_metadata_kv{.key = std::move(key)}); - builder.add_raw_kv(reflection::to_iobuf(std::move(kv.key)), std::nullopt); + builder.add_raw_kv(std::move(kv.key), std::nullopt); } } // namespace