Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of / as division operator in dart sass 2.0 #168

Closed
lizsugar opened this issue Jan 3, 2023 · 2 comments
Closed

Deprecation of / as division operator in dart sass 2.0 #168

lizsugar opened this issue Jan 3, 2023 · 2 comments

Comments

@lizsugar
Copy link

lizsugar commented Jan 3, 2023

Environment

  • Basically Basic version: 1.4.5
  • Ruby gem or remote theme version: ruby gem
  • Jekyll version: 4.3.1
  • Operating system: Windows and Linux

Expected behavior

A smooth clean site build without any issues

Steps to reproduce the behavior

Running bundle exec jekyll build results in errors being thrown regarding the / operator being deprecated.

output.txt

I have attempted to resolve these issues on https://github.com/lizsugar/jekyll-theme-basically-basic/tree/dart-sass-2.0-updates, which now builds a site without errors. However, I now end up with the font scaling no longer working right.

How it looks before / is turned into math.div():
site-normal

How it looks afterwards:
site-small-font

I'm not familiar enough with the project to understand exactly how it was doing that scaling before. If someone could help me out here, that'd be super great :)

@mmistakes
Copy link
Owner

Most of what I’m seeing in the output are warnings about Sass deprecations. The Sass in this project isn’t compatible with Dart Sass as it’s quite old so that’s likely why you’re seeing warnings and issues.

Jekyll has some notes about it, you may need to use the older (and deprecated) Ruby Sass.
https://jekyllrb.com/news/2022/12/21/jekyll-sass-converter-3.0-released/

Here’s an issue on how to lock Jekyll’s Sass converter gem to the older version which should hopefully get around the errors.
jekyll/jekyll-sass-converter#145 (comment)

Other than that the Sass partials would need to be refactored to support Dart Sass which isn’t something I will be getting to anytime soon.

As far as the fluid type partial. More context there on its inner workings can be found here:
https://www.madebymike.com.au/writing/fluid-type-calc-examples/

@lizsugar
Copy link
Author

lizsugar commented Jan 4, 2023

Even better lol. Thank you so much for the quick response!

@lizsugar lizsugar closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants