We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write_raw_bids
electrodes.tsv
I suppose I will label this as a bug, as the current behaviour is inconsistent with the BIDS standard, per discussion in #1006
write_raw_bids shouldn't write stim channels to the electrodes.tsv sidecar file, because stim channels don't have associated electrodes.
I can amend the code in _write_electrodes_tsv, and submit a PR. I will suggest something like:
_write_electrodes_tsv
if ch['kind'] == FIFF.FIFFV_STIM_CH: continue
at the beginning of this for loop:
mne-bids/mne_bids/dig.py
Lines 140 to 152 in 54d50f6
The text was updated successfully, but these errors were encountered:
+1 on fixing this, I like your proposal!
Edit: I'd add a log message with severity DEBUG too
DEBUG
Sorry, something went wrong.
Okay! included a logger.debug message and submitted a PR!
logger.debug
Successfully merging a pull request may close this issue.
I suppose I will label this as a bug, as the current behaviour is inconsistent with the BIDS standard, per discussion in #1006
write_raw_bids
shouldn't write stim channels to theelectrodes.tsv
sidecar file, because stim channels don't have associated electrodes.I can amend the code in
_write_electrodes_tsv
, and submit a PR. I will suggest something like:at the beginning of this for loop:
mne-bids/mne_bids/dig.py
Lines 140 to 152 in 54d50f6
The text was updated successfully, but these errors were encountered: