From 7c95262f7dd51c819f5d8f18ae54427b05797938 Mon Sep 17 00:00:00 2001
From: Erik Bernhardsson <mail@erikbern.com>
Date: Mon, 29 Jul 2024 19:47:22 -0400
Subject: [PATCH] Split the step_completed function (#2058)

---
 modal/_output.py   | 10 ++++------
 modal/_resolver.py |  4 ++--
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/modal/_output.py b/modal/_output.py
index a7c6e7c89..edc5ec5a9 100644
--- a/modal/_output.py
+++ b/modal/_output.py
@@ -70,14 +70,12 @@ def step_progress_update(spinner: Spinner, message: str):
     spinner.update(text=message)
 
 
-def step_completed(message: str, is_substep: bool = False) -> RenderableType:
-    """Returns the element to be rendered when a step is completed."""
+def step_completed(message: str) -> RenderableType:
+    return f"[green]✓[/green] {message}"
 
-    STEP_COMPLETED = "[green]✓[/green]"
-    SUBSTEP_COMPLETED = "🔨"
 
-    symbol = SUBSTEP_COMPLETED if is_substep else STEP_COMPLETED
-    return f"{symbol} {message}"
+def substep_completed(message: str) -> RenderableType:
+    return f"🔨 {message}"
 
 
 def download_progress_bar() -> Progress:
diff --git a/modal/_resolver.py b/modal/_resolver.py
index 214e17d6d..0c2453c41 100644
--- a/modal/_resolver.py
+++ b/modal/_resolver.py
@@ -36,11 +36,11 @@ def message(self, message):
             step_progress_update(self._spinner, message)
 
     def finish(self, message):
-        from ._output import step_completed, step_progress_update
+        from ._output import step_progress_update, substep_completed
 
         if self._step_node is not None:
             step_progress_update(self._spinner, message)
-            self._step_node.label = step_completed(message, is_substep=True)
+            self._step_node.label = substep_completed(message)
 
 
 class Resolver: