From d52f776a8403e5c713c8df1251bdf4b1b015e648 Mon Sep 17 00:00:00 2001 From: Erik Bernhardsson Date: Mon, 29 Jul 2024 20:10:25 -0400 Subject: [PATCH] Remove useless function `step_progress_update` (#2059) Remove useless function step_progress_update --- modal/_output.py | 6 +----- modal/_resolver.py | 8 +++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/modal/_output.py b/modal/_output.py index edc5ec5a9..6c771fb99 100644 --- a/modal/_output.py +++ b/modal/_output.py @@ -66,10 +66,6 @@ def step_progress(text: str = "") -> Spinner: return Spinner(default_spinner, text, style="blue") -def step_progress_update(spinner: Spinner, message: str): - spinner.update(text=message) - - def step_completed(message: str) -> RenderableType: return f"[green]✓[/green] {message}" @@ -311,7 +307,7 @@ def tasks_at_state(state): message = f"[blue]{message}[/blue] [grey70]View app at [underline]{self._app_page_url}[/underline][/grey70]" # Set the new message - step_progress_update(self._status_spinner, message) + self._status_spinner.update(text=message) def update_snapshot_progress(self, image_id: str, task_progress: api_pb2.TaskProgress) -> None: # TODO(erikbern): move this to sit on the resolver object, mostly diff --git a/modal/_resolver.py b/modal/_resolver.py index 0c2453c41..8fd69b3f8 100644 --- a/modal/_resolver.py +++ b/modal/_resolver.py @@ -30,16 +30,14 @@ def __init__(self, progress: "Optional[Tree]"): self._step_node = progress.add(self._spinner) def message(self, message): - from ._output import step_progress_update - if self._spinner is not None: - step_progress_update(self._spinner, message) + self._spinner.update(text=message) def finish(self, message): - from ._output import step_progress_update, substep_completed + from ._output import substep_completed if self._step_node is not None: - step_progress_update(self._spinner, message) + self._spinner.update(text=message) self._step_node.label = substep_completed(message)