Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning objective #24

Open
vsuarezpaniagua opened this issue Jul 15, 2021 · 0 comments
Open

Learning objective #24

vsuarezpaniagua opened this issue Jul 15, 2021 · 0 comments

Comments

@vsuarezpaniagua
Copy link

Hi @monologg! Just a theoretical question about what the BERT for Joint Intent Classification and Slot Filling publication says here:

The learning objective is to maximize the conditional probability p(y^i, y^s|x). The model is finetuned end-to-end via minimizing the cross-entropy loss.

If I understand correctly, this is not to sum the intent and slot losses as you have in your models (total_loss = intent_loss + self.args.slot_loss_coef * slot_loss). If that part of the paper is correct, you should first multiply the probabilities calculated from both logits and then use the CrossEntropyLoss over these probabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant